On Tue, Jan 14, 2020 at 09:37:51AM +0100, Auger Eric wrote: > > In all cases, I see that virtio_iommu_mr() is introduced but not used. > > Would be good to put it into the patch where it's firstly used. > OK fair enough, I will put the helper in the same patch as the user as > you have requested that since the beginning ;-) The resulting patch may > be huge. Just hope nobody will request me to split it back ;-)
We can wait for a few more days and see whether someone will have a different answer before you start to squash things. :) In all cases, I think we should get rid of the compiler trick at least. Thanks, -- Peter Xu