On Tue, Jan 14, 2020 at 2:43 AM Alex Bennée <alex.ben...@linaro.org> wrote: > > As Laurent said I think LOG_UNIMP is perfectly fine for stuff we haven't > done. I don't think any of the cases warrant LOG_GUEST_ERROR.
I've replaced `LOG_USER` with `LOG_UNIMP`. Didn't catch that mask at first, LOG_UNIMP is indeed a better fit for most of these. > I'm not sure want to bother with this. I know we like to avoid > regression but isn't this all debug log stuff? If we must keep it can we > invert the variable to save the initialisation. I'm all for removing it. I agree that it would be pretty odd for someone to depend on debug log output in this way. I've removed this in v2. It is a backwards incompatibility though, so I'm happy to re-add the fix if people want it. > I mean we jumped through hoops to maintain backwards compatibility and > then added new output? Also LOG_STRACE doesn't exist yet. This is leftover debug statements. I've removed it. > I'm not sure we shouldn't just be asserting this case above. The > comments imply it is a bug on our part. The rest look like good cases > for LOG_UNIMP. Switched to an assert in v2.