* Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > > > When run with vhost-user options we conect to the QEMU instead > > via a socket. Start this off by creating the socket. > > > > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > --- > > <snip> > > + /* > > + * Poison the fuse FD so we spot if we accidentally use it; > > + * DO NOT check for this value, check for fuse_lowlevel_is_virtio() > > + */ > > + se->fd = 0xdaff0d11; > </snip> > > As a result of this, se->fd now holds dummy fd. > So we should remove close(se->fd) in fuse_session_destroy(): > https://gitlab.com/virtio-fs/qemu/blob/virtio-fs-dev/tools/virtiofsd/fuse_lowlevel.c#L2663
Thanks; the easier fix here is to remove the dummy 0xdaff0d11 value and just use -1 - it was quite a useful trick when I first did this to find places where we were accidentally using the fd when we shouldn't, but it's not really needed now we got it going. > Reviewed-by: Misono Tomohiro <misono.tomoh...@jp.fujitsu.com> Thanks. -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
