On 06/10/2011 01:05 PM, Stefan Weil wrote:
Variable 'snap' is assigned a value that is never used. Remove snap and the related code.v2: The unused variable which was in function rbd_open is now in function qemu_rbd_create, so the patch needed an update. Cc: Christian Brunner<c...@muc.de> Cc: Josh Durgin<josh.dur...@dreamhost.com> Cc: Kevin Wolf<kw...@redhat.com> Signed-off-by: Stefan Weil<w...@mail.berlios.de> --- block/rbd.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index bdc448a..d5659cd 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -227,7 +227,6 @@ static int qemu_rbd_create(const char *filename, QEMUOptionParameter *options) char name[RBD_MAX_IMAGE_NAME_SIZE]; char snap_buf[RBD_MAX_SNAP_NAME_SIZE]; char conf[RBD_MAX_CONF_SIZE]; - char *snap = NULL; rados_t cluster; rados_ioctx_t io_ctx; int ret; @@ -238,9 +237,6 @@ static int qemu_rbd_create(const char *filename, QEMUOptionParameter *options) conf, sizeof(conf))< 0) { return -EINVAL; } - if (snap_buf[0] != '\0') { - snap = snap_buf; - } /* Read out options */ while (options&& options->name) {
Looks good to me: Reviewed-by: Josh Durgin <josh.dur...@dreamhost.com>
