On Mon, Jan 27, 2020 at 11:47:35AM -0500, Robert Foley wrote:
> On Mon, 27 Jan 2020 at 10:01, Alex Bennée <alex.ben...@linaro.org> wrote:
> > > vm-boot-ssh-%: $(IMAGES_DIR)/%.img
> > > $(call quiet-command, \
> > > - $(SRC_PATH)/tests/vm/$* \
> > > + $(PYTHON) $(SRC_PATH)/tests/vm/$* \
> >
> > This seems like it should be in a different patch.
>
> Good point, will move it to a different patch.
>
> > > +
> > > +DEFAULT_CONFIG = {
> > > + 'cpu' : "max",
> > > + 'machine' : "virt,gic-version=max",
> >
> > According to virt.c:
> >
> > Valid values are 2, 3 and host
> >
> > but max should work on TCG. However we need a more recent QEMU than my
> > system one for it to work. Otherwise you see:
> >
> > DEBUG:qemu.machine:Error launching VM
>
> Good point. We were trying to avoid having different values for KVM
> vs TCG, which we
> could do with the latest QEMU.
> We will update this to make sure this works with older versions of QEMU as
> well.
>
> On my system I have qemu 2.11.1 installed by default.
> It seems that we will need the following defaults based on our environment.
>
> For KVM we end up with the below args since max cpu and max
> gic-version is not available.
> kvm: -cpu host -machine virt,gic-version=host
>
> For TCG max cpu is also not available: qemu-system-aarch64: unable to
> find CPU model 'max',
> so we pick cortex-a57.
> TCG: -cpu cortex-a57 -machine virt,gic-version=3
>
> I suppose we could check the version of QEMU and use the above
> defaults only for earlier versions of QEMU.
> This is something we will probably move to aarch64vm.py since it is common.
What versions of QEMU do these tests *have* to support? Because we could
just skip the tests for QEMU that doesn't support cpu=max,gic-version=max.
'max' is indeed the nicest selection for using the same command line on
KVM (gicv2 and gicv3 hosts) and TCG.
Thanks,
drew
