On 1/28/20 12:56 PM, Dr. David Alan Gilbert wrote:
* Maxim Levitsky (mlevi...@redhat.com) wrote:
Signed-off-by: Maxim Levitsky <mlevi...@redhat.com>

Yes, I think that's OK; I can imagine nbd might want to move on it's own
somewhere since it's not really core block code; copying in Eric.

I think that nbd-server-start and friends ARE related to core block code; they do not work without a BDS node. It's not the same as a block driver, though, in that it is exposing the BDS to the outside world, rather than connecting an outside resource for use internally by the guest.

At any rate, block-hmp-cmds.c seems reasonable enough as a new location for these HMP commands.



Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>

---
  block/monitor/block-hmp-cmds.c     | 88 ++++++++++++++++++++++++++++++
  include/block/block-hmp-commands.h |  5 ++
  include/monitor/hmp.h              |  4 --
  monitor/hmp-cmds.c                 | 87 -----------------------------
  4 files changed, 93 insertions(+), 91 deletions(-)

Reviewed-by: Eric Blake <ebl...@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


Reply via email to