Kevin Wolf <kw...@redhat.com> writes: > Move all of the QMP commands handlers to implement the 'control' module > (qapi/control.json) that can be shared between the system emulator and > tools such as a storage daemon to a new file monitor/qmp-cmds-control.c. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- [...] > diff --git a/monitor/qmp-cmds-control.c b/monitor/qmp-cmds-control.c > new file mode 100644 > index 0000000000..dc789de3f8 > --- /dev/null > +++ b/monitor/qmp-cmds-control.c > @@ -0,0 +1,153 @@ > +/* > + * QMP commands related to the monitor (common functions for sysemu and > tools)
Rather long line. Let's s/common functions for/common to/. The parenthesis is aspirational. I'd add it when it becomes factual, but I'm willing to accept it even now. [...] With the comment tweak: Reviewed-by: Markus Armbruster <arm...@redhat.com>
