Juan Quintela <quint...@redhat.com> writes: > This will store the compression method to use. We start with none. > > Signed-off-by: Juan Quintela <quint...@redhat.com> > Reviewed-by: Markus Armbruster <arm...@redhat.com>
I don't remember giving my R-by. I gave my Acked-by for [PATCH v2 06/10] migration: Add multifd-compress parameter Message-ID: <87d0cku5hq....@dusky.pond.sub.org> https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg04153.html If I did give my R-by for a later revision, let me know. One small suggestion below. > Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> [...] > diff --git a/qapi/migration.json b/qapi/migration.json > index b7348d0c8b..96a126751c 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -488,6 +488,19 @@ > ## > { 'command': 'query-migrate-capabilities', 'returns': > ['MigrationCapabilityStatus']} > > +## > +# @MultiFDMethod: > +# > +# An enumeration of multifd compression. Suggest "compression methods." > +# > +# @none: no compression. > +# > +# Since: 5.0 > +# > +## > +{ 'enum': 'MultiFDMethod', > + 'data': [ 'none' ] } > + > ## > # @MigrationParameter: > # > @@ -586,6 +599,9 @@ > # @max-cpu-throttle: maximum cpu throttle percentage. > # Defaults to 99. (Since 3.1) > # > +# @multifd-method: Which compression method to use. > +# Defaults to none. (Since 5.0) > +# > # Since: 2.4 > ## > { 'enum': 'MigrationParameter', > @@ -598,7 +614,7 @@ > 'downtime-limit', 'x-checkpoint-delay', 'block-incremental', > 'multifd-channels', > 'xbzrle-cache-size', 'max-postcopy-bandwidth', > - 'max-cpu-throttle' ] } > + 'max-cpu-throttle', 'multifd-method' ] } > > ## > # @MigrateSetParameters: > @@ -688,6 +704,9 @@ > # @max-cpu-throttle: maximum cpu throttle percentage. > # The default value is 99. (Since 3.1) > # > +# @multifd-method: Which compression method to use. > +# Defaults to none. (Since 5.0) > +# > # Since: 2.4 > ## > # TODO either fuse back into MigrationParameters, or make > @@ -713,7 +732,8 @@ > '*multifd-channels': 'int', > '*xbzrle-cache-size': 'size', > '*max-postcopy-bandwidth': 'size', > - '*max-cpu-throttle': 'int' } } > + '*max-cpu-throttle': 'int', > + '*multifd-method': 'MultiFDMethod' } } > > ## > # @migrate-set-parameters: > @@ -823,6 +843,9 @@ > # Defaults to 99. > # (Since 3.1) > # > +# @multifd-method: Which compression method to use. > +# Defaults to none. (Since 5.0) > +# > # Since: 2.4 > ## > { 'struct': 'MigrationParameters', > @@ -846,7 +869,8 @@ > '*multifd-channels': 'uint8', > '*xbzrle-cache-size': 'size', > '*max-postcopy-bandwidth': 'size', > - '*max-cpu-throttle':'uint8'} } > + '*max-cpu-throttle': 'uint8', > + '*multifd-method': 'MultiFDMethod' } } > > ## > # @query-migrate-parameters: [...]
