On Mon, Feb 03, 2020 at 05:08:58PM +0100, Thomas Huth wrote: > On 03/02/2020 04.23, Cleber Rosa wrote: > > At this point it seems that all jobs depend on those steps, with > > maybe the EDK2 jobs as exceptions. > > > > The jobs that will be added will not want those scripts to be > > run, so let's move these steps to the appropriate jobs, while > > still trying to avoid repetition. > > > > Signed-off-by: Cleber Rosa <cr...@redhat.com> > > --- > > .gitlab-ci.yml | 17 ++++++++++++++--- > > 1 file changed, 14 insertions(+), 3 deletions(-) > > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > > index 228783993e..d2c7d2198e 100644 > > --- a/.gitlab-ci.yml > > +++ b/.gitlab-ci.yml > > @@ -1,11 +1,10 @@ > > include: > > - local: '/.gitlab-ci-edk2.yml' > > > > -before_script: > > +build-system1: > > + before_script: &before_scr_apt > > - apt-get update -qq > > - apt-get install -y -qq flex bison libglib2.0-dev libpixman-1-dev > > genisoimage > > - > > -build-system1: > > script: > > - apt-get install -y -qq libgtk-3-dev libvte-dev nettle-dev libcacard-dev > > libusb-dev libvde-dev libspice-protocol-dev libgl1-mesa-dev > > libvdeplug-dev > > I'm not very familiar with these anchors yet, but would it maybe be > possible to keep the "template" out of build-system1 ? Something like > they show on https://docs.gitlab.com/ee/ci/yaml/#anchors ? >
Me neither! In fact, thanks for the link above (I simply replayed something I did on another YAML file and validated it on the GitLab CI linter). > Anyway, patch is also fine for me in its current shape, so FWIW: > > Acked-by: Thomas Huth <th...@redhat.com> I'll check out the other possible approaches and let you know. Thanks, - Cleber.
signature.asc
Description: PGP signature
