Hi Philippe, Thanks for all your feedback. I' get your comments addressed soon.
I'm sorry you had trouble applying this patch. The target/hexagon/imported/encode.def should have been created by patch 17. Did you apply that one? Taylor > -----Original Message----- > From: Philippe Mathieu-Daudé <phi...@redhat.com> > Sent: Tuesday, February 11, 2020 1:02 AM > To: Taylor Simpson <tsimp...@quicinc.com>; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com > Subject: Re: [RFC PATCH 55/66] Hexagon HVX import instruction encodings > > > +#define EXTNAME mmvec > > +#include "mmvec/encode_ext.def" > > +#undef EXTNAME > > diff --git a/target/hexagon/imported/encode.def > b/target/hexagon/imported/encode.def > > index 33c3396..d1b3510 100644 > > --- a/target/hexagon/imported/encode.def > > +++ b/target/hexagon/imported/encode.def > > @@ -71,6 +71,7 @@ > > > > #include "encode_pp.def" > > #include "encode_subinsn.def" > > +#include "allextenc.def" > > > > #ifdef __SELF_DEF_FIELD32 > > #undef __SELF_DEF_FIELD32 > > I had a problem applying this one: > > Applying: Hexagon HVX import instruction encodings > error: target/hexagon/imported/encode.def: does not exist in index > Patch failed at 0054 Hexagon HVX import instruction encodings > hint: Use 'git am --show-current-patch' to see the failed patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > > Resolved by doing: > > (review/hexagon|AM 54/65)$ touch target/hexagon/imported/encode.def > (review/hexagon|AM 54/65)$ git add target/hexagon/imported/encode.def > (review/hexagon|AM 54/65)$ git am --continue > Applying: Hexagon HVX import instruction encodings > Applying: Hexagon HVX import semantics > ...
