On 2/6/20 4:49 AM, Max Reitz wrote:
+ /* Filtered child */
+ BDRV_CHILD_FILTERED = (1 << 2),
I'm not sure this comment does justice for what the flag represents, but
am not sure of what longer comment to put in its place.
You’re right. I thought I could just rely on our .is_filter
documentation (at least after
but that doesn’t really apply here.
For example, this series makes raw (without further parameters) have a
CHILD_FILTERED child, without raw being a filter itself.
So there should indeed be some definition here.
A child to which the parent forwards all reads and writes. Therefore,
this child presents exactly the same visible data as the parent.
On second thought, the “therefore” is wrong, because the first sentence
applies to quorum, but the logical conclusion does not.
So maybe rather:
A child to which the parent forwards all reads and writes. It must
present exactly the same visible data as the parent.
Any node may have at most one filtered child at a time.
Yes, this works for me.
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org