On Wed, 12 Feb 2020 at 06:39, Gavin Shan <gs...@redhat.com> wrote: > > On 2/5/20 10:05 PM, Gavin Shan wrote: > > This allows to inject SError interrupt, which will be used on receiving > > QMP/HMP "nmi" command in next patch. > > > > Signed-off-by: Gavin Shan <gs...@redhat.com> > > --- > > target/arm/cpu.c | 11 +++++++++++ > > target/arm/cpu.h | 12 +++++++++--- > > target/arm/helper.c | 4 ++++ > > 3 files changed, 24 insertions(+), 3 deletions(-) > > > > Hi Peter, could you please take a look when you get a chance? I'm not sure > the implementation is good enough to inject SError. If there are somebody > else who can help to review, please let me know so that I can copy her/him > either.
Yeah, this is on my list to look at; Richard Henderson also could have a look at it. From a quick scan I suspect you may be missing handling for AArch32. thanks -- PMM