Move smp_cpus member from VirtMachineState to ArmMachineState. Cc: Michael S. Tsirkin <m...@redhat.com> Cc: Igor Mammedov <imamm...@redhat.com> Cc: Shannon Zhao <shannon.zha...@gmail.com> Signed-off-by: Xu Yandong <xuyando...@huawei.com> --- hw/arm/virt-acpi-build.c | 4 ++-- hw/arm/virt.c | 12 ++++++------ include/hw/arm/arm.h | 1 + include/hw/arm/virt.h | 3 +-- 4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 27e6c95eca..ef2761ef77 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -623,7 +623,7 @@ build_madt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) gicd->base_address = cpu_to_le64(memmap[VIRT_GIC_DIST].base); gicd->version = vms->gic_version; - for (i = 0; i < vms->smp_cpus; i++) { + for (i = 0; i < ams->smp_cpus; i++) { AcpiMadtGenericCpuInterface *gicc = acpi_data_push(table_data, sizeof(*gicc)); ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(i)); @@ -742,7 +742,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) * the RTC ACPI device at all when using UEFI. */ scope = aml_scope("\\_SB"); - acpi_dsdt_add_cpus(scope, vms->smp_cpus); + acpi_dsdt_add_cpus(scope, ams->smp_cpus); acpi_dsdt_add_uart(scope, &memmap[VIRT_UART], (irqmap[VIRT_UART] + ARM_SPI_BASE)); acpi_dsdt_add_flash(scope, &memmap[VIRT_FLASH]); diff --git a/hw/arm/virt.c b/hw/arm/virt.c index e7eee13385..9031fd6757 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -300,7 +300,7 @@ static void fdt_add_timer_nodes(const VirtMachineState *vms) if (vms->gic_version == 2) { irqflags = deposit32(irqflags, GIC_FDT_IRQ_PPI_CPU_START, GIC_FDT_IRQ_PPI_CPU_WIDTH, - (1 << vms->smp_cpus) - 1); + (1 << ams->smp_cpus) - 1); } qemu_fdt_add_subnode(ams->fdt, "/timer"); @@ -342,7 +342,7 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms) * The simplest way to go is to examine affinity IDs of all our CPUs. If * at least one of them has Aff3 populated, we set #address-cells to 2. */ - for (cpu = 0; cpu < vms->smp_cpus; cpu++) { + for (cpu = 0; cpu < ams->smp_cpus; cpu++) { ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(cpu)); if (armcpu->mp_affinity & ARM_AFF3_MASK) { @@ -355,7 +355,7 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms) qemu_fdt_setprop_cell(ams->fdt, "/cpus", "#address-cells", addr_cells); qemu_fdt_setprop_cell(ams->fdt, "/cpus", "#size-cells", 0x0); - for (cpu = vms->smp_cpus - 1; cpu >= 0; cpu--) { + for (cpu = ams->smp_cpus - 1; cpu >= 0; cpu--) { char *nodename = g_strdup_printf("/cpus/cpu@%d", cpu); ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(cpu)); CPUState *cs = CPU(armcpu); @@ -366,7 +366,7 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms) armcpu->dtb_compatible); if (vms->psci_conduit != QEMU_PSCI_CONDUIT_DISABLED - && vms->smp_cpus > 1) { + && ams->smp_cpus > 1) { qemu_fdt_setprop_string(ams->fdt, nodename, "enable-method", "psci"); } @@ -525,7 +525,7 @@ static void fdt_add_pmu_nodes(const VirtMachineState *vms) if (vms->gic_version == 2) { irqflags = deposit32(irqflags, GIC_FDT_IRQ_PPI_CPU_START, GIC_FDT_IRQ_PPI_CPU_WIDTH, - (1 << vms->smp_cpus) - 1); + (1 << ams->smp_cpus) - 1); } armcpu = ARM_CPU(qemu_get_cpu(0)); @@ -1641,7 +1641,7 @@ static void machvirt_init(MachineState *machine) exit(1); } - vms->smp_cpus = smp_cpus; + ams->smp_cpus = smp_cpus; if (vms->virt && kvm_enabled()) { error_report("mach-virt: KVM does not support providing " diff --git a/include/hw/arm/arm.h b/include/hw/arm/arm.h index 97cb902b6a..469f603e77 100644 --- a/include/hw/arm/arm.h +++ b/include/hw/arm/arm.h @@ -89,6 +89,7 @@ typedef struct { MachineState parent; MemMapEntry *memmap; const int *irqmap; + int smp_cpus; void *fdt; int fdt_size; } ArmMachineState; diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h index 4028821a09..dfc2a16010 100644 --- a/include/hw/arm/virt.h +++ b/include/hw/arm/virt.h @@ -71,7 +71,6 @@ typedef struct { int32_t gic_version; VirtIOMMUType iommu; struct arm_boot_info bootinfo; - int smp_cpus; uint32_t clock_phandle; uint32_t gic_phandle; uint32_t msi_phandle; @@ -104,7 +103,7 @@ static inline int virt_gicv3_redist_region_count(VirtMachineState *vms) assert(vms->gic_version == 3); - return vms->smp_cpus > redist0_capacity ? 2 : 1; + return ams->smp_cpus > redist0_capacity ? 2 : 1; } #endif /* QEMU_ARM_VIRT_H */ -- 2.18.1