On Wed, Feb 12, 2020 at 02:42:49PM +0100, David Hildenbrand wrote: > @@ -178,13 +183,15 @@ void *qemu_ram_mmap(int fd, > size_t offset, total; > void *ptr, *guardptr; > > + g_assert(QEMU_IS_ALIGNED(size, pagesize));
(NOTE: assertion is fine, but as I mentioned in previous patch, I think this pagesize could not be the real one that's going to be mapped...) > + > /* > * Note: this always allocates at least one extra page of virtual address > * space, even if size is already aligned. > */ > total = size + align; > > - guardptr = mmap_reserve(total, fd); > + guardptr = mmap_reserve(0, total, fd); s/0/NULL/ Reviewed-by: Peter Xu <pet...@redhat.com> -- Peter Xu