On Fri, 21 Feb 2020 at 15:31, Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Fri, Feb 21, 2020 at 03:16:29PM +0000, Peter Maydell wrote: > > On Thu, 20 Feb 2020 at 14:20, Kashyap Chamarthy <kcham...@redhat.com> wrote: > > > diff --git a/docs/system/conf.py b/docs/system/conf.py > > > index 7ca115f5e0..7cc9da9508 100644 > > > --- a/docs/system/conf.py > > > +++ b/docs/system/conf.py > > > @@ -18,5 +18,8 @@ html_theme_options['description'] = u'System Emulation > > > User''s Guide' > > > man_pages = [ > > > ('qemu-block-drivers', 'qemu-block-drivers', > > > u'QEMU block drivers reference', > > > + ['Fabrice Bellard and the QEMU Project developers'], 7), > > > + ('qemu-cpu-models', 'qemu-cpu-models', > > > + u'QEMU CPU Models', > > > ['Fabrice Bellard and the QEMU Project developers'], 7) > > > ] > > > > The old manpage/documentation credits Dan as the author, > > so that's what we should specify in the conf.py line, > > rather than 'Fabrice and the project devs' (which we > > use for qemu-block-drivers.7 because that's what the > > old texi version of that file specified as the authors). > > I agree that listing Fabrice explicitly here is wrong > since he didn't write any of it. > > As the author, I don't feel a need for my name to be > explicitly credited here. QEMU is a collaborative project > and other people add text to this over time. Indeed IME > explicitly listing an individual encourages users to > directly email the individual person with questions, > instead of using the mailing list / irc / forums. > > Thus I would personally prefer if we just used > > "The QEMU Project maintainers" > > as the author credit
Sure, if you want to update the author credit (which you originally picked in commit 2544e9e4aa2bcef :-)) we can do that, though our standard phrasing (see the QEMU_COPYRIGHT #define in qemu-common.h) is "The QEMU Project developers" so I'd rather we stuck with that than "maintainers". Mostly I want to avoid our rST conversion accidentally dropping or changing existing authorship/attribution information, so maybe we should change the authorship in a follow-on patch. thanks -- PMM