I limited myself to truly trivial fixes. I hope that's still useful enough to excuse a little rant.
"bug: 0 0" is not a useful error message. Neither are "Desc next is 128", " too short" (too short indeed), "wrong magic" (some "wrong magic" skills will be handy to figure out what went wrong). I'm stopping here for brevity's sake, not for want of examples. If you can't be bothered to provide an intelligible error message and *test* it to verify it actually makes sense for the user, maybe you should stick to assert() or something. Makes your laziness stand out properly. Markus Armbruster (5): sheepdog: qemu_bh_new() can't return null pointer, drop check Strip trailing '\n' from error_report()'s first argument qemu-img: Don't prepend qemu-img to error messages twice. Spell "unkown" correctly in error_report() arguments blockdev: Put space after comma in error message block-migration.c | 2 +- block/qcow2.c | 2 +- block/sheepdog.c | 90 ++++++++++++++++++++++------------------------- blockdev.c | 2 +- hw/lm32_sys.c | 2 +- hw/lm32_timer.c | 4 +- hw/lm32_uart.c | 4 +- hw/milkymist-ac97.c | 4 +- hw/milkymist-memcard.c | 4 +- hw/milkymist-minimac2.c | 6 ++-- hw/milkymist-pfpu.c | 4 +- hw/milkymist-softusb.c | 8 ++-- hw/milkymist-sysctl.c | 4 +- hw/milkymist-tmu2.c | 8 ++-- hw/qdev.c | 2 +- hw/strongarm.c | 4 +- hw/usb-ccid.c | 2 +- hw/virtio-serial-bus.c | 10 +++--- hw/virtio.c | 4 +- net.c | 2 +- net/socket.c | 6 ++-- qemu-error.c | 2 + qemu-img.c | 12 +++--- 23 files changed, 92 insertions(+), 96 deletions(-) -- 1.7.2.3
