On Mon, 24 Feb 2020 23:28:24 +0900,
Peter Maydell wrote:
>
> On Sun, 23 Feb 2020 at 13:33, Yoshinori Sato <ys...@users.sourceforge.jp>
> wrote:
> >
> > Signed-off-by: Yoshinori Sato <ys...@users.sourceforge.jp>
> > ---
> > hw/rx/rx-virt.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c
> > index 6cf7936201..4ee6647728 100644
> > --- a/hw/rx/rx-virt.c
> > +++ b/hw/rx/rx-virt.c
> > @@ -90,8 +90,10 @@ static void rxvirt_init(MachineState *machine)
> >
> > /* Load kernel and dtb */
> > if (kernel_filename) {
> > - /* The kernel image is loaded into
> > - the latter half of the SDRAM space. */
> > + /*
> > + The kernel image is loaded into
> > + the latter half of the SDRAM space.
> > + */
>
> The comment format we prefer is described in CODING_STYLE.rst;
> for block comments, and it looks like this:
> /*
> * Leading and closing slash-star and star-slash
> * on their own line; each other line has a star
> * in the left column.
> */
>
> thanks
> -- PMM
My local file using your suggested style.
91 /* Load kernel and dtb */
92 if (kernel_filename) {
93 /*
94 * The kernel image is loaded into
95 * the latter half of the SDRAM space.
96 */
97 kernel_offset = machine->ram_size / 2;
98 rx_load_image(RXCPU(first_cpu), kernel_filename,
99 SDRAM_BASE + kernel_offset, kernel_offset);
Check that I may make a mistake in the file.
--
Yosinori Sato
