From: Elena Ufimtseva <elena.ufimts...@oracle.com>
Synchronize the runstate of the remote process with that of QEMU
Signed-off-by: Elena Ufimtseva <elena.ufimts...@oracle.com>
Signed-off-by: John G Johnson <john.g.john...@oracle.com>
Signed-off-by: Jagannathan Raman <jag.ra...@oracle.com>
---
hw/proxy/qemu-proxy.c | 26 ++++++++++++++++++++++++++
include/hw/proxy/qemu-proxy.h | 2 ++
include/io/mpqemu-link.h | 8 ++++++++
include/sysemu/runstate.h | 1 +
qdev-monitor.c | 11 ++++++++++-
remote/remote-main.c | 5 +++++
remote/remote-opts.c | 5 +++++
runstate.c | 5 +++++
8 files changed, 62 insertions(+), 1 deletion(-)
diff --git a/hw/proxy/qemu-proxy.c b/hw/proxy/qemu-proxy.c
index 1649f60..5876957 100644
--- a/hw/proxy/qemu-proxy.c
+++ b/hw/proxy/qemu-proxy.c
@@ -15,6 +15,7 @@
#include "hw/pci/pci.h"
#include "qapi/qmp/qjson.h"
#include "qapi/qmp/qstring.h"
+#include "sysemu/runstate.h"
#include "hw/proxy/qemu-proxy.h"
#include "hw/proxy/memory-sync.h"
#include "qom/object.h"
@@ -765,6 +766,27 @@ static void init_proxy(PCIDevice *dev, char *command, char
*exec_name,
}
}
+static void proxy_vm_state_change(void *opaque, int running, RunState state)
+{
+ PCIProxyDev *dev = opaque;
+ MPQemuMsg msg = { 0 };
+ int wait = -1;
+
+ msg.cmd = RUNSTATE_SET;
+ msg.bytestream = 0;
+ msg.size = sizeof(msg.data1);
+ msg.data1.runstate.state = state;
+
+ wait = eventfd(0, EFD_CLOEXEC);
+ msg.num_fds = 1;
+ msg.fds[0] = wait;
+
+ mpqemu_msg_send(&msg, dev->mpqemu_link->com);
+
+ wait_for_remote(wait);
+ close(wait);
+}
+
static void pci_proxy_dev_realize(PCIDevice *device, Error **errp)
{
PCIProxyDev *dev = PCI_PROXY_DEV(device);
@@ -782,6 +804,8 @@ static void pci_proxy_dev_realize(PCIDevice *device, Error
**errp)
}
}
+ dev->vmcse = qemu_add_vm_change_state_handler(proxy_vm_state_change, dev);
+
dev->set_proxy_sock = set_proxy_sock;
dev->get_proxy_sock = get_proxy_sock;
dev->init_proxy = init_proxy;
@@ -807,6 +831,8 @@ static void pci_dev_exit(PCIDevice *pdev)
if (!QLIST_EMPTY(&proxy_dev_list.devices)) {
start_broadcast_timer();
}
+
+ qemu_del_vm_change_state_handler(dev->vmcse);
}
static void send_bar_access_msg(PCIProxyDev *dev, MemoryRegion *mr,
diff --git a/include/hw/proxy/qemu-proxy.h b/include/hw/proxy/qemu-proxy.h
index 537c227..6784298 100644
--- a/include/hw/proxy/qemu-proxy.h
+++ b/include/hw/proxy/qemu-proxy.h
@@ -76,6 +76,8 @@ struct PCIProxyDev {
ProxyMemoryRegion region[PCI_NUM_REGIONS];
+ VMChangeStateEntry *vmcse;
+
uint64_t migsize;
};
diff --git a/include/io/mpqemu-link.h b/include/io/mpqemu-link.h
index 01371fc..beb8293 100644
--- a/include/io/mpqemu-link.h
+++ b/include/io/mpqemu-link.h
@@ -20,6 +20,8 @@
#include "exec/cpu-common.h"
#include "exec/hwaddr.h"
+#include "qapi/qapi-types-run-state.h"
+
#define TYPE_MPQEMU_LINK "mpqemu-link"
#define MPQEMU_LINK(obj) \
OBJECT_CHECK(MPQemuLinkState, (obj), TYPE_MPQEMU_LINK)
@@ -65,6 +67,7 @@ typedef enum {
DEVICE_RESET,
START_MIG_OUT,
START_MIG_IN,
+ RUNSTATE_SET,
MAX,
} mpqemu_cmd_t;
@@ -115,6 +118,10 @@ typedef struct {
} mmio_ret_msg_t;
typedef struct {
+ RunState state;
+} runstate_msg_t;
+
+typedef struct {
mpqemu_cmd_t cmd;
int bytestream;
size_t size;
@@ -126,6 +133,7 @@ typedef struct {
set_irqfd_msg_t set_irqfd;
ret_pci_info_msg_t ret_pci_info;
mmio_ret_msg_t mmio_ret;
+ runstate_msg_t runstate;
} data1;
int fds[REMOTE_MAX_FDS];
diff --git a/include/sysemu/runstate.h b/include/sysemu/runstate.h
index ece939f..8c5810f 100644
--- a/include/sysemu/runstate.h
+++ b/include/sysemu/runstate.h
@@ -8,6 +8,7 @@ extern RunState current_run_state;
bool runstate_check(RunState state);
void runstate_set(RunState new_state);
+void remote_runstate_set(RunState state);
int runstate_is_running(void);
bool runstate_needs_reset(void);
bool runstate_store(char *str, size_t size);
diff --git a/qdev-monitor.c b/qdev-monitor.c
index f120509..8efa1a8 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -35,6 +35,7 @@
#include "qemu/option_int.h"
#include "sysemu/block-backend.h"
#include "sysemu/sysemu.h"
+#include "sysemu/runstate.h"
#include "migration/misc.h"
#include "migration/migration.h"
#include "qemu/cutils.h"
@@ -674,6 +675,7 @@ DeviceState *qdev_proxy_add(const char *rid, const char
*id, char *bus,
const char *str;
bool need_spawn = false;
bool remote_exists = false;
+ char *command = NULL;
if (strlen(rid) > MAX_RID_LENGTH) {
error_setg(errp, "rid %s is too long.", rid);
@@ -743,11 +745,18 @@ DeviceState *qdev_proxy_add(const char *rid, const char
*id, char *bus,
need_spawn = true;
}
- pdev->init_proxy(PCI_DEVICE(ds), cmd, exec_name, need_spawn, errp);
+ if (runstate_check(RUN_STATE_INMIGRATE)) {
+ command = g_strdup_printf("%s %s", cmd, "-incoming defer");
+ } else {
+ command = g_strdup(cmd);
+ }
+
+ pdev->init_proxy(PCI_DEVICE(ds), command, exec_name, need_spawn, errp);
QLIST_INSERT_HEAD(&proxy_dev_list.devices, pdev, next);
qemu_opts_del(proxy_opts);
+
return ds;
}
diff --git a/remote/remote-main.c b/remote/remote-main.c
index e97eb76..0260c7c 100644
--- a/remote/remote-main.c
+++ b/remote/remote-main.c
@@ -31,6 +31,7 @@
#include "qemu/main-loop.h"
#include "qemu/config-file.h"
#include "sysemu/sysemu.h"
+#include "sysemu/runstate.h"
#include "block/block.h"
#include "exec/ramlist.h"
#include "exec/memattrs.h"
@@ -454,6 +455,10 @@ static void process_msg(GIOCondition cond, MPQemuChannel
*chan)
case START_MIG_OUT:
process_start_mig_out(msg);
break;
+ case RUNSTATE_SET:
+ remote_runstate_set(msg->data1.runstate.state);
+ notify_proxy(msg->fds[0], 0);
+ break;
default:
error_setg(&err, "Unknown command");
goto finalize_loop;
diff --git a/remote/remote-opts.c b/remote/remote-opts.c
index e22ad5c..839baf1 100644
--- a/remote/remote-opts.c
+++ b/remote/remote-opts.c
@@ -40,8 +40,10 @@
#include "remote/remote-opts.h"
#include "include/qemu-common.h"
#include "monitor/monitor.h"
+#include "sysemu/runstate.h"
#include "vl.h"
+
/*
* In remote process, we parse only subset of options. The code
* taken from vl.c to re-use in remote command line parser.
@@ -85,6 +87,9 @@ void parse_cmdline(int argc, char **argv, char **envp)
case QEMU_OPTION_qmp:
monitor_parse(optarg, "control", false);
break;
+ case QEMU_OPTION_incoming:
+ remote_runstate_set(RUN_STATE_INMIGRATE);
+ break;
case QEMU_OPTION_monitor:
if (!strncmp(optarg, "stdio", 5)) {
warn_report("STDIO not supported in remote process");
diff --git a/runstate.c b/runstate.c
index 273345a..9c5c627 100644
--- a/runstate.c
+++ b/runstate.c
@@ -34,3 +34,8 @@ bool runstate_check(RunState state)
{
return current_run_state == state;
}
+
+void remote_runstate_set(RunState state)
+{
+ current_run_state = state;
+}
--
1.8.3.1
