>-----Original Message-----
>From: Kevin Wolf [mailto:kw...@redhat.com]
>Sent: Wednesday, February 26, 2020 5:55 PM
>To: Chenqun (kuhn) <kuhn.chen...@huawei.com>
>Cc: qemu-devel@nongnu.org; qemu-triv...@nongnu.org;
>peter.mayd...@linaro.org; Zhanghailiang <zhang.zhanghaili...@huawei.com>;
>Euler Robot <euler.ro...@huawei.com>; Ronnie Sahlberg
><ronniesahlb...@gmail.com>; Paolo Bonzini <pbonz...@redhat.com>; Peter
>Lieven <p...@kamp.de>; Max Reitz <mre...@redhat.com>
>Subject: Re: [PATCH v2 02/13] block/iscsi:Remove redundant statement in
>iscsi_open()
>
>Am 26.02.2020 um 09:46 hat kuhn.chen...@huawei.com geschrieben:
>> From: Chen Qun <kuhn.chen...@huawei.com>
>>
>> Clang static code analyzer show warning:
>> block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
>> flags &= ~BDRV_O_RDWR;
>> ^ ~~~~~~~~~~~~
>>
>> Reported-by: Euler Robot <euler.ro...@huawei.com>
>> Signed-off-by: Chen Qun <kuhn.chen...@huawei.com>
>
>Hmm, I'm not so sure about this one because if we remove the line, flags will
>be inconsistent with bs->open_flags. It feels like setting a trap for anyone
>who wants to add code using flags in the future.
Hi Kevin,
I find it exists since 8f3bf50d34037266. : )
It's not a big deal, just upset clang static code analyzer.
As you said, it could be a trap for the future.
It ’s okay, whether it exists or not.
Thanks.
>
>Kevin
>
>> Cc: Ronnie Sahlberg <ronniesahlb...@gmail.com>
>> Cc: Paolo Bonzini <pbonz...@redhat.com>
>> Cc: Peter Lieven <p...@kamp.de>
>> Cc: Kevin Wolf <kw...@redhat.com>
>> Cc: Max Reitz <mre...@redhat.com>
>> ---
>> block/iscsi.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/block/iscsi.c b/block/iscsi.c index
>> 682abd8e09..ed88479ede 100644
>> --- a/block/iscsi.c
>> +++ b/block/iscsi.c
>> @@ -1917,7 +1917,6 @@ static int iscsi_open(BlockDriverState *bs, QDict
>*options, int flags,
>> if (ret < 0) {
>> goto out;
>> }
>> - flags &= ~BDRV_O_RDWR;
>> }
>>
>> iscsi_readcapacity_sync(iscsilun, &local_err);
>> --
>> 2.23.0
>>
>>
