On 02.03.2020 18:11, Paolo Bonzini wrote: > On 03/02/20 12:41, Philippe Mathieu-Daudé wrote: >> >> Maybe you can add something like: >> >> if test "$targetos" = "NetBSD"; then >> nvmm="check" >> fi > > You could do just nvmm="" and, below, > > if test "$nvmm" != "no" && test "$targetos" = "NetBSD" > > But maybe even testing NetBSD is not needed since nvmm.h will likely not > be there. > > Paolo >
I have got no opinion here. I can just change on request nvmm="yes" to nvmm="check" and be done. >> to build by default with NVMM if available. >> >>> +########################################## >>> +# NetBSD Virtual Machine Monitor (NVMM) accelerator check >>> +if test "$nvmm" != "no" ; then >>> + if check_include "nvmm.h" ; then >>> + nvmm="yes" >>> + LIBS="-lnvmm $LIBS" >>> + else >>> + if test "$nvmm" = "yes"; then >>> + feature_not_found "NVMM" "NVMM is not available" >>> + fi >>> + nvmm="no" >>> + fi >>> +fi >
