On Thu, Mar 05, 2020 at 02:50:47PM +0100, Philippe Mathieu-Daudé wrote: > On 3/5/20 2:48 PM, Stefano Garzarella wrote: > > On Thu, Mar 05, 2020 at 02:44:03PM +0100, Stefano Garzarella wrote: > > > On Thu, Mar 05, 2020 at 01:45:18PM +0100, Philippe Mathieu-Daudé wrote: > > > > This buffer is only used by the adlib audio device. Move it to > > > > the .heap to release 32KiB of .bss (size reported on x86_64 host). > > > > > > > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > > > --- > > > > hw/audio/fmopl.c | 4 +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c > > > > index 173a7521f2..356d4dfbca 100644 > > > > --- a/hw/audio/fmopl.c > > > > +++ b/hw/audio/fmopl.c > > > > @@ -186,7 +186,7 @@ static int32_t *VIB_TABLE; > > > > /* envelope output curve table */ > > > > /* attack + decay + OFF */ > > > > -static int32_t ENV_CURVE[2*EG_ENT+1]; > > > > +static int32_t *ENV_CURVE; > > > > /* multiple table */ > > > > #define ML 2 > > > > @@ -1090,6 +1090,7 @@ FM_OPL *OPLCreate(int clock, int rate) > > > > OPL->clock = clock; > > > > OPL->rate = rate; > > > > OPL->max_ch = max_ch; > > > > + ENV_CURVE = g_new(int32_t, 2 * EG_ENT + 1); > > > > Should we use g_new0() ? > > No because the array is filled before being used. I can add a note about > this. >
Thanks for the clarification! Yes, if you need to respin, maybe it's better. Thanks, Stefano
