On 3/5/20 12:56 AM, Markus Armbruster wrote:
> John Snow <js...@redhat.com> writes:
>
>> On 3/4/20 10:59 AM, Markus Armbruster wrote:
>>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>>> ---
>>> scripts/qapi/commands.py | 2 +-
>>> scripts/qapi/expr.py | 3 +--
>>> scripts/qapi/gen.py | 9 ++++++---
>>> scripts/qapi/introspect.py | 2 --
>>> scripts/qapi/parser.py | 6 ++----
>>> scripts/qapi/schema.py | 11 +++++------
>>> 6 files changed, 15 insertions(+), 18 deletions(-)
>>>
>>
>> Looks okay. (I don't care as much about no-else-return being there or
>> not, and this module is your baby.)
>
> I admit I personally prefer to elide the else there. But my main
> argument is consistent style. Picking the one pylint wants makes
> consistency easier.
>
>> Reviewed-by: John Snow <js...@redhat.com>
>
> Thanks!
>
I capitulated to Max and Kevin who disliked the same, and also
personally agree I like to visually see the branches.
(If we want a tree-wide python style it might be useful to converge the
linting configurations at some point -- but not yet, and it's not as
important as the more nuts and bolts cleanups to remove Python3. RB
stands, of course.)
--js
