On 10.03.20 10:00, David Hildenbrand wrote: > > Now that we talked about cached values, what about > > #if !defined(CONFIG_USER_ONLY) > static bool s390_is_pv(void) > { > static S390CcwMachineState *ccw; > Object *obj; > > if (ccw) { > return ccw->pv; > } > > /* we have to bail out for the "none" machine */ > obj = object_dynamic_cast(qdev_get_machine(), > TYPE_S390_CCW_MACHINE); > if (!obj) { > return false; > } > ccw = S390_CCW_MACHINE(obj); > return ccw->pv; > } > #endif > > and drop all env->pv checks, replacing them by s390_is_pv(). (sorry, > should have recommended that earlier) Yes that makes sense. Now that we have enable/disable we can use the machine pv property.
- Re: [PATCH v7 02/15] s390x: protvirt: Suppo... Christian Borntraeger
- Re: [PATCH v7 02/15] s390x: protvirt: S... David Hildenbrand
- Re: [PATCH v7 02/15] s390x: protvirt: S... Christian Borntraeger
- Re: [PATCH v7 02/15] s390x: protvirt: Suppo... Janosch Frank
- Re: [PATCH v7 02/15] s390x: protvirt: S... David Hildenbrand
- [PATCH v8 1/2] s390x: ipl: Consolidate iplb... Janosch Frank
- [PATCH v8 2/2] s390x: protvirt: Support... Janosch Frank
- Re: [PATCH v8 2/2] s390x: protvirt:... David Hildenbrand
- Re: [PATCH v8 2/2] s390x: prot... Janosch Frank
- Re: [PATCH v8 2/2] s390x: ... David Hildenbrand
- Re: [PATCH v8 2/2] s390x: prot... Christian Borntraeger
- Re: [PATCH v8 1/2] s390x: ipl: Consolid... David Hildenbrand
- Re: [PATCH v8 1/2] s390x: ipl: Consolid... Christian Borntraeger
- [PATCH v8] s390x: ipl: Consolidate ... Janosch Frank
- Re: [PATCH v8] s390x: ipl: Con... Christian Borntraeger
- Re: [PATCH v8] s390x: ipl:... David Hildenbrand
- Re: [PATCH v8] s390x: ipl: Con... Christian Borntraeger
- Re: [PATCH v7 02/15] s390x: protvirt: Support u... Viktor Mihajlovski
- Re: [PATCH v7 02/15] s390x: protvirt: Suppo... Janosch Frank
- [PATCH v7 07/15] s390x: protvirt: Move STSI data ove... Janosch Frank
- [PATCH v7 09/15] s390x: protvirt: Set guest IPL PSW Janosch Frank