On Wed, Mar 11, 2020 at 06:51:46AM -0700, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200311124045.277969-1-stefa...@redhat.com/ ... > === OUTPUT BEGIN === > 1/9 Checking commit 86ac8a79649d (qemu/queue.h: clear linked list pointers on > remove) > ERROR: do not use assignment in if condition > #66: FILE: include/qemu/queue.h:314: > + if (((head)->sqh_first = elm->field.sqe_next) == NULL) \ > > total: 1 errors, 0 warnings, 59 lines checked
This is for consistency with the rest of queue.h, which comes from BSD and does not follow QEMU coding style. Stefan
signature.asc
Description: PGP signature
