On 3/10/20 11:44 PM, Richard Henderson wrote: > +int probe_access_flags(CPUArchState *env, target_ulong addr, > + MMUAccessType access_type, int mmu_idx, > + bool nonfault, void **phost, uintptr_t retaddr) > +{ > + void *host; > + int flags; > + > + flags = probe_access_internal(env, addr, 0, access_type, mmu_idx, > + nonfault, &host, retaddr);
Bug here. Should have passed along phost to probe_access_internal instead of a new local host variable. I've sent a v2 for this patch, in-reply-to. I'll not repost the whole patch set until I've also addressed any review. r~