Greg Kurz's on March 17, 2020 10:20 pm:
> On Tue, 17 Mar 2020 15:02:13 +1000
> Nicholas Piggin <npig...@gmail.com> wrote:
>
>> Add some messages which explain problems and guest misbehaviour that
>> may be difficult to diagnose in rare cases of machine checks.
>>
>> Signed-off-by: Nicholas Piggin <npig...@gmail.com>
>> ---
>> hw/ppc/spapr_events.c | 4 ++++
>> hw/ppc/spapr_rtas.c | 4 ++++
>> 2 files changed, 8 insertions(+)
>>
>> diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c
>> index 05337f0671..d35151eeb0 100644
>> --- a/hw/ppc/spapr_events.c
>> +++ b/hw/ppc/spapr_events.c
>> @@ -807,6 +807,8 @@ static void spapr_mce_dispatch_elog(PowerPCCPU *cpu,
>> bool recovered)
>> /* get rtas addr from fdt */
>> rtas_addr = spapr_get_rtas_addr();
>> if (!rtas_addr) {
>> + warn_report("FWNMI: Unable to deliver machine check to guest: "
>> + "rtas_addr not found.");
>
> Why a warning and not an error ?
>
> Also maybe change the string to fit on one line ?
Not sure, I guess it should be.
Thanks,
Nick
