25.03.2020 16:08, Eric Blake wrote:
On 3/25/20 5:21 AM, Vladimir Sementsov-Ogievskiy wrote:
When sending iotests to upstream or do patch porting from one branch
to another we very often have to resolve conflicts in group file, as
many absolutely independent features are intersecting by this file.
These conflicts are simple, but imagine how much time we all have
already spent on resolving them? Let's finally get rid of group file.
Next, another thing I don't like about iotests is race for test number
chosing: you should search through mail box, before chosing test number
for new test.
So, I propose to get rid of group file and search for tests another way
[look at patch 02]. Additionally I propose to move to human-readable
names for test files, with notation test-* .
I suggest swapping the name: It's easier to write a glob for *-test vs.
*-test.out than it is to write for test-* but not test-*.out. (You don't want
to execute the output files as a test). That is, I suggest that ./check
consider all 3-digit files and all files ending in -test as tests.
I like the idea. It also helps typing test name in terminal: stre<TAB> -> stream-test instead
of te<TAB>stre<TAB> -> test-stream.
v1 was one patch "[PATCH] iotests: drop group file"
Vladimir Sementsov-Ogievskiy (2):
iotests: define group in each iotests
iotests: rework test finding
Do you plan on an additional patch (or set of patches) to rename some or all of
the existing 3-digit tests?
I think, I'll rename tests that I've written.
Overall, having sensibly named tests makes sense to me.
If we are going to rename files, I'd also suggest that we rename the directory:
tests/qemu-iotests/ feels redundant, compared to tests/iotests.