* Peter Xu (pet...@redhat.com) wrote:
> kvm_vm_ioctl() handles the errno trick already for ioctl() on
> returning -1 for errors. Fix this.
>
> Signed-off-by: Peter Xu <pet...@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
> ---
> accel/kvm/kvm-all.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index c111312dfd..4be3cd2352 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -688,14 +688,13 @@ static int kvm_log_clear_one_slot(KVMSlot *mem, int
> as_id, uint64_t start,
> d.num_pages = bmap_npages;
> d.slot = mem->slot | (as_id << 16);
>
> - if (kvm_vm_ioctl(s, KVM_CLEAR_DIRTY_LOG, &d) == -1) {
> - ret = -errno;
> + ret = kvm_vm_ioctl(s, KVM_CLEAR_DIRTY_LOG, &d);
> + if (ret) {
> error_report("%s: KVM_CLEAR_DIRTY_LOG failed, slot=%d, "
> "start=0x%"PRIx64", size=0x%"PRIx32", errno=%d",
> __func__, d.slot, (uint64_t)d.first_page,
> (uint32_t)d.num_pages, ret);
> } else {
> - ret = 0;
> trace_kvm_clear_dirty_log(d.slot, d.first_page, d.num_pages);
> }
>
> --
> 2.24.1
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
