Mao Zhongyi <maozhon...@cmss.chinamobile.com> wrote:
> use QERR_INVALID_PARAMETER_VALUE instead of
> "Parameter '%s' expects" for consistency.
I agree with the idea.
> Signed-off-by: Mao Zhongyi <maozhon...@cmss.chinamobile.com>
> ---
> migration/migration.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 2b7b5bccfa..e0223f3b15 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1202,16 +1202,17 @@ static bool migrate_params_check(MigrationParameters
> *params, Error **errp)
> }
>
> if (params->has_max_bandwidth && (params->max_bandwidth > SIZE_MAX)) {
> - error_setg(errp, "Parameter 'max_bandwidth' expects an integer in
> the"
> - " range of 0 to %zu bytes/second", SIZE_MAX);
> + error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
> + "max_bandwidth",
> + "an integer in the range of 0 to '2^64 - 1'
> bytes/second");
> return false;
> }
You are inlining the constants. What about:
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
"max_bandwidth",
"an integer in the range of 0 to '" stringify(SIZE_MAX)
"'bytes/second");
Same for the others.
Thanks, Juan.
