On Fri, 3 Apr 2020 at 14:53, Daniel P. Berrangé <berra...@redhat.com> wrote: > > Running configure directly from the source directory is a build > configuration that will go away in future. It is also not currently > covered by any automated testing. Display a deprecation warning if > the user attempts to use an in-srcdir build setup, so that they are > aware that they're building QEMU in an undesirable manner. > > Reviewed-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Markus Armbruster <arm...@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > ---
> +if test "$in_srcdir" = "yes"; then > + echo > + echo "WARNING: SUPPORT FOR BUILDING IN THE SOURCE DIR IS DEPRECATED" > + echo > + echo "Support for running the 'configure' script directly from the" > + echo "source directory is deprecated. In-tree builds are not covered" > + echo "by automated testing and thus may not correctly build QEMU." > + echo "Users are recommended to use a separate build directory:" > + echo > + echo " $ mkdir build" > + echo " $ cd build" > + echo " $ ../configure" > + echo " $ make" > + echo > +fi So here's my stab at some text here; I'm aiming at nudging users towards out-of-tree builds if they were simply not thinking about it, but not actively marking them as 'deprecated', since it sounded to me like we were planning to keep at least the basic 'configure+make+make install' sequence of commands working. echo "NOTE: we recommend against building in the source directory" echo echo "You've run the 'configure' script directly from the source" echo "directory. This will work, but we recommend using a separate" echo "build directory, especially if you plan to work with the QEMU" echo "sources rather than just building it once. You can switch to" echo "a separate build directory like this:" [instructions go here] thanks -- PMM
