Re: [PATCH-for-5.1 v2 38/54] hw/arm/bcm2835_peripherals: Add missing error-propagation code

[Philippe Mathieu-Daudé]

On 4/6/20 7:47 PM, Philippe Mathieu-Daudé wrote:
Patch created mechanically by running:
   $ spatch \
     --macro-file scripts/cocci-macro-file.h --include-headers \
     --sp-file scripts/coccinelle/object_property_missing_error_propagate.cocci 
\

sigh I forgot to update this, the scrip has been renamed 
add-missing-error_propagate.cocci :(

     --keep-comments --smpl-spacing --in-place --dir hw

Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
---
  hw/arm/bcm2835_peripherals.c | 8 ++++++++
  1 file changed, 8 insertions(+)

diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c
index edcaa4916d..a111e91069 100644
--- a/hw/arm/bcm2835_peripherals.c
+++ b/hw/arm/bcm2835_peripherals.c
@@ -289,8 +289,16 @@ static void bcm2835_peripherals_realize(DeviceState *dev, 
Error **errp)
       *   SD3.0_Host_AHB_eMMC4.4_Usersguide_ver5.9_jan11_10.pdf
       */
      object_property_set_uint(OBJECT(&s->sdhci), 3, "sd-spec-version", &err);
+    if (err) {
+        error_propagate(errp, err);
+        return;
+    }
      object_property_set_uint(OBJECT(&s->sdhci), BCM2835_SDHC_CAPAREG, 
"capareg",
                               &err);
+    if (err) {
+        error_propagate(errp, err);
+        return;
+    }
      object_property_set_bool(OBJECT(&s->sdhci), true, "pending-insert-quirk",
                               &err);
      if (err) {