On Thu, Apr 09, 2020 at 08:36:22PM +0200, Laurent Vivier wrote: > Le 09/04/2020 à 20:22, Peter Xu a écrit : > > On Thu, Apr 09, 2020 at 07:25:08PM +0200, Philippe Mathieu-Daudé wrote: > >> Since a010bdbe719 the gdbstub API takes a GByteArray*. > >> Unfortunately we forgot to update the gdb_get_reg*() > >> calls. Do it now. > >> > >> Fixes: a010bdbe719 ("extend GByteArray to read register helpers") > > > > Should this be instead 462474d760 ("target/m68k: use gdb_get_reg > > helpers", 2020-03-17)? > > No, this one is correct because it uses an "uint8_t *", then a010bdbe719 > changed this to a GByteArray and didn't remove the "+ len".
Ah right... -- Peter Xu