On 4/11/20 11:29 AM, Peter Maydell wrote: > When kernel-doc generates a 'c:function' directive for a function > one of whose arguments is a function pointer, it fails to print > the close-paren after the argument list of the function pointer > argument, for instance: > .. c:function:: void memory_region_init_resizeable_ram (MemoryRegion * mr, > struct Object * owner, const char * name, uint64_t size, uint64_t max_size, > void (*resized) (const char*, uint64_t length, void *host, Error ** errp) > > which should have a ')' after the 'void *host' which is the > last argument to 'resized'. > > Older versions of Sphinx don't try to parse the argumnet > to c:function, but Sphinx 3.0 does do this and will complain: > > > /home/petmay01/linaro/qemu-from-laptop/qemu/docs/../include/exec/memory.h:834: > WARNING: Error in declarator or parameters > Invalid C declaration: Expecting "," or ")" in parameters, got "EOF". > [error at 208] > void memory_region_init_resizeable_ram (MemoryRegion * mr, struct Object > * owner, const char * name, uint64_t size, uint64_t max_size, void (*resized) > (const char*, uint64_t length, void *host, Error ** errp) > > ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------^ > > Add the missing close-paren. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > scripts/kernel-doc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
