On 4/15/20 9:25 AM, Klaus Birkelund Jensen wrote:
On Apr 15 09:14, Philippe Mathieu-Daudé wrote:
Hi Klaus,
This patch is a pain to review... Could you split it? I'd use one trivial
patch for each function extracted from nvme_realize().
Understood, I will split it up!
Thanks, that will help the review.
As this series is quite big, I recommend you to split it, so part of it
can get merged quicker and you don't have to carry tons of patches that
scare reviewers/maintainers.
Suggestions:
- 1: cleanups/refactors
- 2: support v1.3
- 3: more refactors, strengthening code
- 4: improve DMA & S/G
- 5: support for multiple NS
- 6: tests for multiple NS feature
- 7: tests bus unplug/replug (idea)
Or less :)
