On 4/21/20 3:19 PM, Philippe Mathieu-Daudé wrote:
A KVM-only build won't be able to run TCG cpus.

Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
---
This patch review is funnier using:
'git-diff --color-moved=dimmed-zebra'
---
  target/arm/cpu.c         | 634 -------------------------------------
  target/arm/cpu_tcg.c     | 663 +++++++++++++++++++++++++++++++++++++++
  target/arm/Makefile.objs |   1 +
  3 files changed, 664 insertions(+), 634 deletions(-)
  create mode 100644 target/arm/cpu_tcg.c
[...]
diff --git a/target/arm/cpu_tcg.c b/target/arm/cpu_tcg.c
new file mode 100644
index 0000000000..899d3ac7bc
--- /dev/null
+++ b/target/arm/cpu_tcg.c
@@ -0,0 +1,663 @@
+/*
+ * ARM generic helpers.
+ * QEMU ARM CPU

Here I meant one line "QEMU ARM TCG CPU" instead of "ARM generic helpers. QEMU ARM CPU"

+ *
+ * This code is licensed under the GNU GPL v2 or later.
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+#include "qemu/osdep.h"
+#include "cpu.h"
+#include "internals.h"
+
+/* CPU models. These are not needed for the AArch64 linux-user build. */
+#if !defined(CONFIG_USER_ONLY) || !defined(TARGET_AARCH64)[...]


Reply via email to