On 17/04/20 09:44, Yan Zhao wrote:
> for ram device regions, drop guest writes if the regions is read-only.
>
> Cc: Philippe Mathieu-Daudé <phi...@redhat.com>
> Signed-off-by: Yan Zhao <yan.y.z...@intel.com>
> Signed-off-by: Xin Zeng <xin.z...@intel.com>
> ---
> memory.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/memory.c b/memory.c
> index 601b749906..9576dd6807 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -34,6 +34,7 @@
> #include "sysemu/accel.h"
> #include "hw/boards.h"
> #include "migration/vmstate.h"
> +#include "qemu/log.h"
>
> //#define DEBUG_UNASSIGNED
>
> @@ -1313,6 +1314,12 @@ static void memory_region_ram_device_write(void
> *opaque, hwaddr addr,
> MemoryRegion *mr = opaque;
>
> trace_memory_region_ram_device_write(get_cpu_index(), mr, addr, data,
> size);
> + if (mr->readonly) {
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "Invalid write to read only ram device region 0x%"
> + HWADDR_PRIx" size %u\n", addr, size);
> + return;
> + }
As mentioned in the review of v1, memory_region_ram_device_write should
be changed to a .write_with_attrs operation, so that it can return
MEMTX_ERROR.
Otherwise this looks good.
Paolo
