> -----Original Message-----
> From: Lukas Straub <lukasstra...@web.de>
> Sent: Monday, April 27, 2020 5:19 AM
> To: qemu-devel <qemu-devel@nongnu.org>
> Cc: Zhang, Chen <chen.zh...@intel.com>; Li Zhijian
> <lizhij...@cn.fujitsu.com>; Jason Wang <jasow...@redhat.com>; Marc-
> André Lureau <marcandre.lur...@redhat.com>; Paolo Bonzini
> <pbonz...@redhat.com>
> Subject: [PATCH v3 4/6] net/colo-compare.c: Only hexdump packets if tracing
> is enabled
>
> Else the log will be flooded if there is a lot of network traffic.
>
> Signed-off-by: Lukas Straub <lukasstra...@web.de>
>
Looks good for me.
Reviewed-by: Zhang Chen <chen.zh...@intel.com>
---
> net/colo-compare.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/net/colo-compare.c b/net/colo-compare.c index
> ff6a740284..6634911770 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -479,10 +479,12 @@ sec:
> g_queue_push_head(&conn->primary_list, ppkt);
> g_queue_push_head(&conn->secondary_list, spkt);
>
> - qemu_hexdump((char *)ppkt->data, stderr,
> - "colo-compare ppkt", ppkt->size);
> - qemu_hexdump((char *)spkt->data, stderr,
> - "colo-compare spkt", spkt->size);
> + if
> (trace_event_get_state_backends(TRACE_COLO_COMPARE_MISCOMPARE))
> {
> + qemu_hexdump((char *)ppkt->data, stderr,
> + "colo-compare ppkt", ppkt->size);
> + qemu_hexdump((char *)spkt->data, stderr,
> + "colo-compare spkt", spkt->size);
> + }
>
> colo_compare_inconsistency_notify(s);
> }
> --
> 2.20.1
