On 24.03.20 16:08, Janosch Frank wrote: > Why should we do conversion of a ebcdic value if we have a handy table > where we coul look up the ascii value instead? > > Signed-off-by: Janosch Frank <fran...@linux.ibm.com> > --- > pc-bios/s390-ccw/bootmap.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c > index d13b7cbd1597bf2e..97205674e59aebb2 100644 > --- a/pc-bios/s390-ccw/bootmap.c > +++ b/pc-bios/s390-ccw/bootmap.c > @@ -328,9 +328,7 @@ static void print_eckd_ldl_msg(ECKD_IPL_mode_t mode) > msg[0] = '2'; > break; > default: > - msg[0] = vlbl->LDL_version; > - msg[0] &= 0x0f; /* convert EBCDIC */ > - msg[0] |= 0x30; /* to ASCII (digit) */ > + msg[0] = ebc2asc[vlbl->LDL_version]; > msg[1] = '?'; > break; > } >
Reviewed-by: David Hildenbrand <da...@redhat.com> -- Thanks, David / dhildenb
