On Fri, May 1, 2020 at 6:01 PM Bin Meng <bmeng...@gmail.com> wrote: > > From: Bin Meng <bin.m...@windriver.com> > > To keep sync with other RISC-V machines, change the default bios > to use .bin instead of the .elf images. > > Signed-off-by: Bin Meng <bin.m...@windriver.com> > --- > > hw/riscv/spike.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c > index d0c4843..611a741 100644 > --- a/hw/riscv/spike.c > +++ b/hw/riscv/spike.c > @@ -46,9 +46,9 @@ > #include <libfdt.h> > > #if defined(TARGET_RISCV32) > -# define BIOS_FILENAME "opensbi-riscv32-spike-fw_jump.elf" > +# define BIOS_FILENAME "opensbi-riscv32-spike-fw_jump.bin" > #else > -# define BIOS_FILENAME "opensbi-riscv64-spike-fw_jump.elf" > +# define BIOS_FILENAME "opensbi-riscv64-spike-fw_jump.bin" > #endif
This change breaks the console on the spike machine because HTIF emulation depends on ELF parsing. Keeping here ELF files was intentional because BIN files dont work for Spike the machine. Also, now that OpenSBI generic platform is available. We can use same OpenSBI firmware binaries/elfs on virt, sifive_u, and spike machines of QEMU. I think: 1. The QEMU build/makefile scripts for OpenSBI should be updated to only build OpenSBI generic platform firmwares 2. The default BIOS_FILENAME in for virt, sifive_u, and spike machines should be changed to use OpenSBI generic platform firmwares. It would be great if you can drop this patch and instead do above two changes. Agree ?? Regards, Anup
