Patchew URL: https://patchew.org/QEMU/20200501113704.2240698-1-patr...@stwcx.xyz/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200501113704.2240698-1-patr...@stwcx.xyz Subject: [PATCH] aspeed: Add support for the sonorapass-bmc board Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20200501113704.2240698-1-patr...@stwcx.xyz -> patchew/20200501113704.2240698-1-patr...@stwcx.xyz Switched to a new branch 'test' aab540d aspeed: Add support for the sonorapass-bmc board === OUTPUT BEGIN === ERROR: do not use C99 // comments #53: FILE: hw/arm/aspeed.c:394: + // bus 2 : ERROR: do not use C99 // comments #56: FILE: hw/arm/aspeed.c:397: + // bus 2 : pca9546 @ 0x73 ERROR: do not use C99 // comments #58: FILE: hw/arm/aspeed.c:399: + // bus 3 : pca9548 @ 0x70 ERROR: do not use C99 // comments #60: FILE: hw/arm/aspeed.c:401: + // bus 4 : ERROR: space prohibited after that open parenthesis '(' #61: FILE: hw/arm/aspeed.c:402: + uint8_t *eeprom4_54 = g_malloc0( 8 * 1024 ); ERROR: space prohibited before that close parenthesis ')' #61: FILE: hw/arm/aspeed.c:402: + uint8_t *eeprom4_54 = g_malloc0( 8 * 1024 ); ERROR: do not use C99 // comments #69: FILE: hw/arm/aspeed.c:410: + // bus 6 : ERROR: do not use C99 // comments #72: FILE: hw/arm/aspeed.c:413: + // bus 6 : pca9546 @ 0x73 ERROR: do not use C99 // comments #74: FILE: hw/arm/aspeed.c:415: + // bus 8 : ERROR: space prohibited after that open parenthesis '(' #75: FILE: hw/arm/aspeed.c:416: + uint8_t *eeprom8_56 = g_malloc0( 8 * 1024 ); ERROR: space prohibited before that close parenthesis ')' #75: FILE: hw/arm/aspeed.c:416: + uint8_t *eeprom8_56 = g_malloc0( 8 * 1024 ); ERROR: do not use C99 // comments #80: FILE: hw/arm/aspeed.c:421: + // bus 8 : adc128d818 @ 0x1d ERROR: do not use C99 // comments #81: FILE: hw/arm/aspeed.c:422: + // bus 8 : adc128d818 @ 0x1f ERROR: do not use C99 // comments #83: FILE: hw/arm/aspeed.c:424: + // bus 13 : pca9548 @ 0x71 ERROR: do not use C99 // comments #84: FILE: hw/arm/aspeed.c:425: + // - channel 3: ERROR: do not use C99 // comments #85: FILE: hw/arm/aspeed.c:426: + // - tmm421 @ 0x4c ERROR: do not use C99 // comments #86: FILE: hw/arm/aspeed.c:427: + // - tmp421 @ 0x4e ERROR: do not use C99 // comments #87: FILE: hw/arm/aspeed.c:428: + // - tmp421 @ 0x4f total: 18 errors, 0 warnings, 100 lines checked Commit aab540d961cd (aspeed: Add support for the sonorapass-bmc board) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200501113704.2240698-1-patr...@stwcx.xyz/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com