On 5/5/20 5:29 PM, Markus Armbruster wrote:
Same story as for object_property_add(): the only way
object_property_del() can fail is when the property with this name
does not exist.  Since our property names are all hardcoded, failure
is a programming error, and the appropriate way to handle it is
passing &error_abort.  Most callers do that, the commit before
previous fixed one that didn't (and got the error handling wrong), and
the two remaining exceptions ignore errors.

Drop the @errp parameter.

Signed-off-by: Markus Armbruster <arm...@redhat.com>
Reviewed-by: Paolo Bonzini <pbonz...@redhat.com>
---
  include/qom/object.h       | 2 +-
  hw/core/qdev.c             | 2 +-
  hw/i386/pc_sysfw.c         | 2 +-
  hw/ppc/spapr_drc.c         | 4 ++--
  qom/object.c               | 7 +------
  qom/object_interfaces.c    | 3 +--
  tests/check-qom-proplist.c | 2 +-
  7 files changed, 8 insertions(+), 14 deletions(-)

Nice :)

Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>


Reply via email to