On Wed 06 May 2020 08:13:51 PM CEST, Eric Blake wrote: > On 5/5/20 12:38 PM, Alberto Garcia wrote: >> Extended L2 entries are bigger than normal L2 entries so this has an >> impact on the amount of metadata needed for a qcow2 file. >> >> Signed-off-by: Alberto Garcia <be...@igalia.com> >> Reviewed-by: Max Reitz <mre...@redhat.com> >> --- >> block/qcow2.c | 19 ++++++++++++------- >> 1 file changed, 12 insertions(+), 7 deletions(-) > > Should this be hoisted earlier in the series, before 28/31?
I can do that if I call qcow2_calc_prealloc_size() with extended_l2 always set to false (because there would be no BLOCK_OPT_EXTL2 that the caller could use). Maybe it's not a bad idea. > Should there be iotest coverage? There are already, in the last patch. Berto
