Patchew URL:
https://patchew.org/QEMU/20200513173200.11830-1-alex.ben...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200513173200.11830-1-alex.ben...@linaro.org
Subject: [PATCH v1 0/8] plugins/next (cleanup, cpu_index and lockstep)
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
6edd795 plugins: new lockstep plugin for debugging TCG changes
4202a73 tests/tcg: add new threadcount test
1f6f667 linux-user: properly "unrealize" vCPU object
6200dd7 cpus-common: ensure auto-assigned cpu_indexes don't clash
888408f MAINTAINERS: update the orphaned cpus-common.c file
6c78116 qemu/qemu-plugin: Make qemu_plugin_hwaddr_is_io() hwaddr argument const
ce430e0 qemu/plugin: Move !CONFIG_PLUGIN stubs altogether
e69a9cc qemu/plugin: Trivial code movement
=== OUTPUT BEGIN ===
1/8 Checking commit e69a9cc66e44 (qemu/plugin: Trivial code movement)
2/8 Checking commit ce430e01e1b3 (qemu/plugin: Move !CONFIG_PLUGIN stubs
altogether)
3/8 Checking commit 6c781160c4cd (qemu/qemu-plugin: Make
qemu_plugin_hwaddr_is_io() hwaddr argument const)
4/8 Checking commit 888408f0e702 (MAINTAINERS: update the orphaned
cpus-common.c file)
5/8 Checking commit 6200dd769e32 (cpus-common: ensure auto-assigned cpu_indexes
don't clash)
6/8 Checking commit 1f6f66791a8f (linux-user: properly "unrealize" vCPU object)
7/8 Checking commit 4202a73ecb0e (tests/tcg: add new threadcount test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30:
new file mode 100644
ERROR: open brace '{' following function declarations go on the next line
#62: FILE: tests/tcg/multiarch/threadcount.c:28:
+static void *thread_fn(void* varg) {
ERROR: "foo* bar" should be "foo *bar"
#63: FILE: tests/tcg/multiarch/threadcount.c:29:
+ ThreadArg* arg = varg;
ERROR: open brace '{' following function declarations go on the next line
#69: FILE: tests/tcg/multiarch/threadcount.c:35:
+int main(int argc, char **argv) {
ERROR: "foo* bar" should be "foo *bar"
#79: FILE: tests/tcg/multiarch/threadcount.c:45:
+ ThreadArg* arg = calloc(sizeof(ThreadArg), 1);
total: 4 errors, 1 warnings, 70 lines checked
Patch 7/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/8 Checking commit 6edd795dd0a4 (plugins: new lockstep plugin for debugging
TCG changes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56:
new file mode 100644
ERROR: "foo * bar" should be "foo *bar"
#163: FILE: tests/plugin/lockstep.c:103:
+static inline const char * ord_ind(int n) {
ERROR: open brace '{' following function declarations go on the next line
#163: FILE: tests/plugin/lockstep.c:103:
+static inline const char * ord_ind(int n) {
WARNING: line over 80 characters
#220: FILE: tests/plugin/lockstep.c:160:
+ g_string_append_printf(out, " previously @ %#016lx/%ld (%ld
insns)\n",
ERROR: do not use C99 // comments
#292: FILE: tests/plugin/lockstep.c:232:
+ // save a reference so we can free later
total: 3 errors, 2 warnings, 360 lines checked
Patch 8/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200513173200.11830-1-alex.ben...@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
