On Wed, 13 Jul 2011, Luiz Capitulino wrote: > On Wed, 13 Jul 2011 18:37:31 +0400 (MSD) > malc <av1...@comtv.ru> wrote: > > > On Wed, 13 Jul 2011, Luiz Capitulino wrote: > > > > > From: Luiz Capitulino <lcapitul...@gmail.com> > > > > > > This moves compiler related macros from qemu-common.h to compiler.h. > > > > > > The reason for this change is that there are simple header files that > > > depend only on the compiler macros, so including qemu-common.h is > > > overkill. > > > > > > Besides, qemu-common.h is bloated and will benefit from some splitting. > > > > > > Signed-off-by: Luiz Capitulino <lcapitul...@gmail.com> > > > --- > > > compiler.h | 31 +++++++++++++++++++++++++++++++ > > > qemu-common.h | 25 +------------------------ > > > 2 files changed, 32 insertions(+), 24 deletions(-) > > > create mode 100644 compiler.h > > > > > > diff --git a/compiler.h b/compiler.h > > > new file mode 100644 > > > index 0000000..2dfc2c6 > > > --- /dev/null > > > +++ b/compiler.h > > > @@ -0,0 +1,31 @@ > > > +#ifndef COMPILER_H > > > +#define COMPILER_H > > > + > > > +#include "config-host.h" > > > + > > > +#define QEMU_NORETURN __attribute__ ((__noreturn__)) > > > +#ifdef CONFIG_GCC_ATTRIBUTE_WARN_UNUSED_RESULT > > > +#define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_result)) > > > +#else > > > +#define QEMU_WARN_UNUSED_RESULT > > > +#endif > > > + > > > +#define QEMU_BUILD_BUG_ON(x) typedef char > > > __build_bug_on__##__LINE__[(x)?-1:1]; > > > > Identifiers starting with double underscore are reserved for all uses, > > so, please, use something else. > > I'll fix it as an additional patch:
OK. > > diff --git a/compiler.h b/compiler.h > index 2dfc2c6..54720bf 100644 > --- a/compiler.h > +++ b/compiler.h > @@ -10,7 +10,8 @@ > #define QEMU_WARN_UNUSED_RESULT > #endif > > -#define QEMU_BUILD_BUG_ON(x) typedef char > __build_bug_on__##__LINE__[(x)?-1:1]; > +#define QEMU_BUILD_BUG_ON(x) \ > + typedef char qemu_build_bug_on__##__LINE__[(x)?-1:1]; > > #if defined __GNUC__ > # if (__GNUC__ < 4) || \ > -- mailto:av1...@comtv.ru