On 18/05/2020 06:03, Markus Armbruster wrote: > mac_via_realize() creates a "mos6522-q800-via1" and a > "mos6522-q800-via2" device, but neglects to realize them. Affects > machine q800. > > I wonder how this ever worked. If the "device becomes real only on > realize" thing actually works, then we've always been missing these > two devices, yet nobody noticed. > > Fix by realizing them right away. > > Fixes: 6dca62a0000f95e0b7020aa00d0ca9b2c421f341 > Cc: Laurent Vivier <laur...@vivier.eu> > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > hw/misc/mac_via.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c > index e05623d730..ee32f72d75 100644 > --- a/hw/misc/mac_via.c > +++ b/hw/misc/mac_via.c > @@ -890,6 +890,9 @@ static void mac_via_realize(DeviceState *dev, Error > **errp) > object_property_add_alias(OBJECT(dev), "irq[1]", OBJECT(ms), > SYSBUS_DEVICE_GPIO_IRQ "[0]"); > > + qdev_init_nofail(DEVICE(&m->mos6522_via1)); > + qdev_init_nofail(DEVICE(&m->mos6522_via2)); > + > /* Pass through mos6522 input IRQs */ > qdev_pass_gpios(DEVICE(&m->mos6522_via1), dev, "via1-irq"); > qdev_pass_gpios(DEVICE(&m->mos6522_via2), dev, "via2-irq");
Reviewed-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> ATB, Mark.
