Alistair Francis <alistai...@gmail.com> writes: > On Sun, May 17, 2020 at 10:06 PM Markus Armbruster <arm...@redhat.com> wrote: >> >> stm32f405_soc_initfn() creates six such devices, but >> stm32f405_soc_realize() realizes only one. Affects machine >> netduinoplus2. >> >> I wonder how this ever worked. If the "device becomes real only on >> realize" thing actually works, then we've always been missing five of >> six such devices, yet nobody noticed. > > I must have just been testing the first ADC. > >> >> Fix stm32f405_soc_realize() to realize all six. Visible in "info >> qtree": >> >> bus: main-system-bus >> type System >> dev: stm32f405-soc, id "" >> cpu-type = "cortex-m4-arm-cpu" >> dev: stm32f2xx-adc, id "" >> gpio-out "sysbus-irq" 1 >> - mmio ffffffffffffffff/00000000000000ff >> + mmio 0000000040012000/00000000000000ff >> dev: stm32f2xx-adc, id "" >> gpio-out "sysbus-irq" 1 >> - mmio ffffffffffffffff/00000000000000ff >> + mmio 0000000040012000/00000000000000ff >> dev: stm32f2xx-adc, id "" >> gpio-out "sysbus-irq" 1 >> - mmio ffffffffffffffff/00000000000000ff >> + mmio 0000000040012000/00000000000000ff >> dev: stm32f2xx-adc, id "" >> gpio-out "sysbus-irq" 1 >> - mmio ffffffffffffffff/00000000000000ff >> + mmio 0000000040012000/00000000000000ff >> dev: stm32f2xx-adc, id "" >> gpio-out "sysbus-irq" 1 >> mmio 0000000040012000/00000000000000ff >> dev: stm32f2xx-adc, id "" >> gpio-out "sysbus-irq" 1 >> - mmio ffffffffffffffff/00000000000000ff >> + mmio 0000000040012000/00000000000000ff >> dev: armv7m, id "" >> >> The mmio addresses look suspicious. > > Good catch, thanks :)
I'd love to squash in corrections, but I don't know the correct addresses. Can you help? >> >> Fixes: 529fc5fd3e18ace8f739afd02dc0953354f39442 >> Cc: Alistair Francis <alist...@alistair23.me> >> Cc: Peter Maydell <peter.mayd...@linaro.org> >> Cc: qemu-...@nongnu.org >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> Thanks!
