On 5/27/20 3:37 PM, Vladimir Sementsov-Ogievskiy wrote:
This is the only coroutine wrapper from block.c and block/io.c which doesn't return value, so let's convert it to the common behavior, to
s/value/a value/
simplify moving to generated coroutine wrappers in further commit.
s/in/in a/
Also, bdrv_invalidate_cache is a void function, returning error only through **errp parameter, which considered to be bad practice, as it
s/which/which is/
forces callers to define and propagate local_err variable, so conversion is good anyway. This patch leaves convertion of .bdrv_co_invalidate_cache() driver
s/convertion/the conversion/
callbacks and bdrv_invalidate_cache_all() for another-day refactoring.
s/another-day refactoring/another day/
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> --- include/block/block.h | 2 +- block.c | 32 ++++++++++++++++++-------------- 2 files changed, 19 insertions(+), 15 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
