Patchew URL: https://patchew.org/QEMU/20200528205114.42078-1-to...@linux.vnet.ibm.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200528205114.42078-1-to...@linux.vnet.ibm.com Subject: [PATCH 0/2] Add support for SEV Launch Secret Injection Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' fefbf6f sev: scan guest ROM for launch secret address 94d7e7b sev: add sev-inject-launch-secret === OUTPUT BEGIN === 1/2 Checking commit 94d7e7bc7c3c (sev: add sev-inject-launch-secret) ERROR: code indent should never use tabs #26: FILE: include/sysemu/sev.h:22: +^I^I uint64_t gpa);$ ERROR: trailing whitespace #45: FILE: qapi/misc-target.json:213: + GPA provided here will be ignored if guest ROM specifies $ ERROR: suspect code indent for conditional statements (4, 6) #72: FILE: target/i386/monitor.c:744: + if (sev_inject_launch_secret(packet_hdr,secret,gpa) != 0) + error_setg(errp, "SEV inject secret failed"); ERROR: space required after that ',' (ctx:VxV) #72: FILE: target/i386/monitor.c:744: + if (sev_inject_launch_secret(packet_hdr,secret,gpa) != 0) ^ ERROR: space required after that ',' (ctx:VxV) #72: FILE: target/i386/monitor.c:744: + if (sev_inject_launch_secret(packet_hdr,secret,gpa) != 0) ^ ERROR: braces {} are necessary for all arms of this statement #72: FILE: target/i386/monitor.c:744: + if (sev_inject_launch_secret(packet_hdr,secret,gpa) != 0) [...] ERROR: code indent should never use tabs #84: FILE: target/i386/sev-stub.c:52: +^I^I uint64_t gpa)$ ERROR: code indent should never use tabs #86: FILE: target/i386/sev-stub.c:54: +^I return 1;$ ERROR: code indent should never use tabs #136: FILE: target/i386/sev.c:776: +^Ierror_report("Not in correct state. %x",sev_state->state);$ ERROR: space required after that ',' (ctx:VxV) #136: FILE: target/i386/sev.c:776: + error_report("Not in correct state. %x",sev_state->state); ^ ERROR: code indent should never use tabs #137: FILE: target/i386/sev.c:777: +^Ireturn 1;$ ERROR: space required after that ',' (ctx:VxV) #170: FILE: target/i386/sev.c:810: + ret = sev_ioctl(sev_state->sev_fd,KVM_SEV_LAUNCH_SECRET, input, &error); ^ ERROR: do not use C99 // comments #207: FILE: tests/qtest/qmp-cmd-test.c:96: + // "query-sev-launch-measure", ERROR: do not use C99 // comments #211: FILE: tests/qtest/qmp-cmd-test.c:98: + // "query-sev", ERROR: do not use C99 // comments #212: FILE: tests/qtest/qmp-cmd-test.c:99: + // "query-sev-capabilities", total: 15 errors, 0 warnings, 163 lines checked Patch 1/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/2 Checking commit fefbf6f8855c (sev: scan guest ROM for launch secret address) ERROR: space required after that ',' (ctx:VxO) #43: FILE: target/i386/sev.c:741: + qemu_uuid_parse(SEV_ROM_SECRET_GUID,&secret_table_guid); ^ ERROR: space required before that '&' (ctx:OxV) #43: FILE: target/i386/sev.c:741: + qemu_uuid_parse(SEV_ROM_SECRET_GUID,&secret_table_guid); ^ ERROR: space required before the open parenthesis '(' #47: FILE: target/i386/sev.c:745: + while(offset > 0) { ERROR: space required before the open brace '{' #49: FILE: target/i386/sev.c:747: + if(qemu_uuid_is_equal(&secret_table_guid, (QemuUUID *) secret_table)){ ERROR: space required before the open parenthesis '(' #49: FILE: target/i386/sev.c:747: + if(qemu_uuid_is_equal(&secret_table_guid, (QemuUUID *) secret_table)){ ERROR: space required before the open parenthesis '(' #64: FILE: target/i386/sev.c:762: + if(!sev_state->secret_gpa) { ERROR: code indent should never use tabs #66: FILE: target/i386/sev.c:764: +^I }$ ERROR: space required after that ',' (ctx:VxV) #76: FILE: target/i386/sev.c:803: + error_report("Not in correct state. %x",sev_state->state); ^ ERROR: space required before the open parenthesis '(' #85: FILE: target/i386/sev.c:819: + if(sev_state->secret_gpa) ERROR: braces {} are necessary for all arms of this statement #85: FILE: target/i386/sev.c:819: + if(sev_state->secret_gpa) [...] total: 10 errors, 0 warnings, 104 lines checked Patch 2/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200528205114.42078-1-to...@linux.vnet.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com