On Mon, 18 May 2020 at 17:41, Richard Henderson <richard.hender...@linaro.org> wrote: > > Create ExcMultiPattern to hold an set of non-overlapping patterns. > The body of build_tree, prop_format become member functions on this > class. Add minimal member functions to Pattern and MultiPattern > to allow recusion through the tree. > > Move the bulk of build_incmulti_pattern to prop_masks and prop_width > in MultiPattern, since we will need this for both kinds of containers. > Only perform prop_width for variablewidth. > > Remove global patterns variable, and pass down container object into > parse_file from main. > > No functional change in all of this. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > scripts/decodetree.py | 464 +++++++++++++++++++++++------------------- > 1 file changed, 253 insertions(+), 211 deletions(-) >
I feel like this would have been easier to review if it had been multiple patches (there's a lot of stuff that's just code-motion in here together with actual changes) but I've waded through it now, so Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
