On Tue, 2 Jun 2020 at 16:21, Alex Bennée <alex.ben...@linaro.org> wrote:
>
>
> Robert Foley <robert.fo...@linaro.org> writes:
<snip>
> >
> >  configure_qemu()
> >  {
> > +    if test -z "$TSAN"; then
> > +        requires clang tsan
> > +        echo "Including TSan Support"
> > +        tsan_log_dir="/tmp/qemu-test/build/tsan"
> > +        mkdir -p $tsan_log_dir > /dev/null || true
> > +        EXTRA_CONFIGURE_OPTS="${EXTRA_CONFIGURE_OPTS} --enable-tsan \
> > +                             --cc=clang-10 --cxx=clang++-10 \
> > +                             --disable-werror --extra-cflags=-O0"
> > +        # detect deadlocks is false currently simply because
> > +        # TSan crashes immediately with deadlock detecter enabled.
> > +        # We have maxed out the history size to get the best chance of 
> > finding
> > +        # warnings during testing.
> > +        # Note, to get tsan to fail on warning, use exitcode=66 below.
> > +        
> > tsan_opts="suppressions=/tmp/qemu-test/src/tests/tsan/suppressions.tsan\
> > +                   detect_deadlocks=false history_size=7\
> > +                   halt_on_error=0 exitcode=0 verbose=5\
> > +                   log_path=$tsan_log_dir/tsan_warnings.txt"
> > +        export TSAN_OPTIONS="$tsan_opts"
> > +    fi
>
> ...I think it would be better to put this in it's own test (test-tsan?)
>

Makes sense, we will put this TSan code in its own separate test.
Sure, test-tsan seems like a good name for this.

Thanks & Regards,
-Rob

> --
> Alex Bennée

Reply via email to